summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAdriaan de Groot <groot@kde.org>2019-02-11 17:27:45 -0500
committerAdriaan de Groot <groot@kde.org>2019-02-11 17:27:45 -0500
commit5863300f67e1dc043a19201fafdf9e30dbcdcd97 (patch)
tree398ddc97dc81d09df1b58bbe60a0792e240e867d
parentabf1f1460453051301c94683ef82d9b34f88c0b0 (diff)
[partition] Use const QString&
- minor code-layout and idiomatic-C++
-rw-r--r--src/modules/partition/core/PartitionLayout.cpp6
-rw-r--r--src/modules/partition/core/PartitionLayout.h4
2 files changed, 5 insertions, 5 deletions
diff --git a/src/modules/partition/core/PartitionLayout.cpp b/src/modules/partition/core/PartitionLayout.cpp
index f8ff79d2c..4f3225e94 100644
--- a/src/modules/partition/core/PartitionLayout.cpp
+++ b/src/modules/partition/core/PartitionLayout.cpp
@@ -53,7 +53,7 @@ PartitionLayout::addEntry( PartitionLayout::PartitionEntry entry )
}
static double
-parseSizeString( QString sizeString, PartitionLayout::SizeUnit *unit )
+parseSizeString( const QString& sizeString, PartitionLayout::SizeUnit* unit )
{
double value;
bool ok;
@@ -103,7 +103,7 @@ parseSizeString( QString sizeString, PartitionLayout::SizeUnit *unit )
}
void
-PartitionLayout::addEntry( QString mountPoint, QString size, QString min )
+PartitionLayout::addEntry( const QString& mountPoint, const QString& size, const QString& min )
{
PartitionLayout::PartitionEntry entry;
@@ -119,7 +119,7 @@ PartitionLayout::addEntry( QString mountPoint, QString size, QString min )
}
void
-PartitionLayout::addEntry( QString label, QString mountPoint, QString fs, QString size, QString min )
+PartitionLayout::addEntry( const QString& label, const QString& mountPoint, const QString& fs, const QString& size, const QString& min )
{
PartitionLayout::PartitionEntry entry;
diff --git a/src/modules/partition/core/PartitionLayout.h b/src/modules/partition/core/PartitionLayout.h
index 8c17c3a9f..65ed1d850 100644
--- a/src/modules/partition/core/PartitionLayout.h
+++ b/src/modules/partition/core/PartitionLayout.h
@@ -61,8 +61,8 @@ public:
~PartitionLayout();
void addEntry( PartitionEntry entry );
- void addEntry( QString mountPoint, QString size, QString min = "" );
- void addEntry( QString label, QString mountPoint, QString fs, QString size, QString min = "" );
+ void addEntry( const QString& mountPoint, const QString& size, const QString& min = QString() );
+ void addEntry( const QString& label, const QString& mountPoint, const QString& fs, const QString& size, const QString& min = QString() );
/**
* @brief Apply the current partition layout to the selected drive space.