summaryrefslogtreecommitdiff
path: root/test/lib-blacklist-test.sh
diff options
context:
space:
mode:
authorIsaac David <isacdaavid@isacdaavid.info>2017-10-13 01:10:06 -0500
committerIsaac David <isacdaavid@isacdaavid.info>2017-10-13 01:10:06 -0500
commit2a7b161e6aa234aa5d434f47d3aedbe48ff7b251 (patch)
tree3ae4a263bcd7b8d5fa0ef5b41798404cc5613ca4 /test/lib-blacklist-test.sh
parentce4bc72dbd590231186267c064ae1679c2ba1241 (diff)
blacklist test: distinguish between empty string and empty line proper
Plenty of functions in libreblacklist are expected to print empty lines, so as to signify that the archpkg at that line in the input has an empty accompanying field. Printing no newline and skipping to the next archpkg is therefore a bug; one that would pass unnoticed by current tests. This is because command substitution removes trailing whitespace. I.e. the following is true: [[ $(libreblacklist get-rep <<<'') == $(libreblacklist get-rep <<<$'\n') ]] Process substitution and pipes preserve whitespace, but only the latter work with #!/usr/bin/env roundup, so we use that.
Diffstat (limited to 'test/lib-blacklist-test.sh')
-rwxr-xr-xtest/lib-blacklist-test.sh12
1 files changed, 6 insertions, 6 deletions
diff --git a/test/lib-blacklist-test.sh b/test/lib-blacklist-test.sh
index 202a2e2..1f8c518 100755
--- a/test/lib-blacklist-test.sh
+++ b/test/lib-blacklist-test.sh
@@ -8,9 +8,9 @@ _blacklist_url=https://projects.parabola.nu/blacklist.git/plain/blacklist.txt
it_works_with_just_pkgname() {
v="$(libreblacklist normalize <<<skype)"; [[ $v == 'skype::::' ]]
v="$(libreblacklist get-pkg <<<skype)"; [[ $v == skype ]]
- v="$(libreblacklist get-rep <<<skype)"; [[ -z $v ]]
- v="$(libreblacklist get-url <<<skype)"; [[ -z $v ]]
- v="$(libreblacklist get-reason <<<skype)"; [[ -z $v ]]
+ libreblacklist get-rep <<<skype | equals $'\n'
+ libreblacklist get-url <<<skype | equals $'\n'
+ libreblacklist get-reason <<<skype | equals $'\n'
}
it_works_with_everything_set() {
@@ -23,7 +23,7 @@ it_works_with_everything_set() {
}
it_normalizes_correctly() {
- v="$(libreblacklist normalize <<<'#comment')"; [[ -z $v ]]
+ libreblacklist normalize <<<'#comment' | equals ''
v="$(libreblacklist normalize <<<pkg)"; [[ $v == 'pkg::::' ]]
v="$(libreblacklist normalize <<<pkg:)"; [[ $v == 'pkg::::' ]]
v="$(libreblacklist normalize <<<pkg::)"; [[ $v == 'pkg::::' ]]
@@ -46,8 +46,8 @@ it_works_with_colons_in_reason() {
}
it_prints_urls_only_for_valid_references() {
- v="$(libreblacklist get-url <<<package:::id:)"; [[ -z $v ]]
- v="$(libreblacklist get-url <<<package::unknown:id:)"; [[ -z $v ]]
+ libreblacklist get-url <<<package:::id: | equals $'\n'
+ libreblacklist get-url <<<package::unknown:id: | equals $'\n'
}
it_fails_update_with_no_blacklist_or_network() {