| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
|
|
- Move a few lines around
- Add comments
- Don't bother checking [[ -n $TEXTDOMAIN ]]/TEXTDOMAINDIR, they're never
set.
- Put the pacman db at "$TEMPDIR/db", not "$TEMPDIR".
- Create a pacman=() variable for storing all of our scratch flags
- Drop the pkglist='' variable; expand it out where used
Altogether, there should be no user-visible changes here
|
|
|
|
This avoids something like a dep on 'systemd-tools' from resolving to
'notsystemd', causing a conflict with 'systemd' in 'base-devel', which
had the 'systemd-tools' dep already filled.
On the downside, this is much slower.
|
|
Objectives:
- Once the source package has been created, never run makepkg with
networking enabled again, so that we can be 100% sure that the source
package has all of the sources that we need.
- Don't let makepkg edit the PKGBUILD (eg. by evaluating pkgver())
User-facing changes:
- libremakepkg now disables networking during prepare()
- libremakepkg no longer runs pkgver()
- chcleanup (and thus `librechroot clean-pkgs`) now also installs packages
Technical description of changes:
- In devtools (and not really in this commit):
* No longer split /chrootprepare off of /chrootbuild. The point of
splitting it was that we'd have prepare() run from /chrootprepare
and the rest later run from /chrootbuild, so that we could leave
networking enabled during prepare() but not the rest. Now that we're
disabling networking during prepare(), that's pointless.
* Have download_sources create a source package (rather than having
/chrootbuild create the source package at the same time that we create
the binary package). We adjust the caller to temporarily set
SRCPKGDEST to a temporary directory, so that we can get the file and
control the filename when we move it in to the real SRCPKGDEST.
- Have chcleanup install the dependencies. If we used the traditional
`makepkg --sync` to install the dependencies, then we'd be breaking the
"no networking for makepkg after source package creation" objective.
chcleanup already has all of the logic necessary to accomplish this.
If there's a discrepancy in chcleanup behavior and makepkg behavior, and
makepkg thinks it needs to install something, then that just means we'll
have to fix the bug in chcleanup, instead of letting it go for more than
a year (*cough* https://labs.parabola.nu/issues/1311 *cough*).
- Use files extracted from the source package (rather than files found in
the current directory) to build the package.
- We mount the temporary directory containing the extracted source package
files read-only, to be sure that makepkg doesn't modify the PKGBUILD.
This is necessary because --holdver only disables pkgver() if it's a VCS
package.
|
|
|
|
|
|
Also, don't parse PKGBUILD ourself; use .SRCINFO to extract
information from the PKGBUILD.
|
|
|
|
Only make this change in places where it shouldn't make a difference, and
something weird has to be going on for the subshell to fail. This is on
par with checking the return value of malloc. We don't need tests for each
of these failure cases.
|
|
These were found with the help of shellcheck.
Nothing more complicated than wrapping a variable in double quotes has been
done.
|
|
|
|
|
|
|
|
|
|
|
