summaryrefslogtreecommitdiff
path: root/includes/specials/SpecialMostlinkedcategories.php
diff options
context:
space:
mode:
Diffstat (limited to 'includes/specials/SpecialMostlinkedcategories.php')
-rw-r--r--includes/specials/SpecialMostlinkedcategories.php22
1 files changed, 14 insertions, 8 deletions
diff --git a/includes/specials/SpecialMostlinkedcategories.php b/includes/specials/SpecialMostlinkedcategories.php
index 7fb9dea9..dadef8bf 100644
--- a/includes/specials/SpecialMostlinkedcategories.php
+++ b/includes/specials/SpecialMostlinkedcategories.php
@@ -40,9 +40,9 @@ class MostlinkedCategoriesPage extends QueryPage {
function getQueryInfo() {
return array (
'tables' => array ( 'category' ),
- 'fields' => array ( 'cat_title AS title',
- NS_CATEGORY . ' AS namespace',
- 'cat_pages AS value' ),
+ 'fields' => array ( 'title' => 'cat_title',
+ 'namespace' => NS_CATEGORY,
+ 'value' => 'cat_pages' ),
);
}
@@ -55,6 +55,10 @@ class MostlinkedCategoriesPage extends QueryPage {
* @param $res DatabaseResult
*/
function preprocessResults( $db, $res ) {
+ if ( !$res->numRows() ) {
+ return;
+ }
+
$batch = new LinkBatch;
foreach ( $res as $row ) {
$batch->add( NS_CATEGORY, $row->title );
@@ -62,10 +66,7 @@ class MostlinkedCategoriesPage extends QueryPage {
$batch->execute();
// Back to start for display
- if ( $db->numRows( $res ) > 0 ) {
- // If there are no rows we get an error seeking.
- $db->dataSeek( $res, 0 );
- }
+ $res->seek( 0 );
}
/**
@@ -76,7 +77,12 @@ class MostlinkedCategoriesPage extends QueryPage {
function formatResult( $skin, $result ) {
global $wgContLang;
- $nt = Title::makeTitle( NS_CATEGORY, $result->title );
+ $nt = Title::makeTitleSafe( NS_CATEGORY, $result->title );
+ if ( !$nt ) {
+ return Html::element( 'span', array( 'class' => 'mw-invalidtitle' ),
+ Linker::getInvalidTitleDescription( $this->getContext(), NS_CATEGORY, $result->title ) );
+ }
+
$text = $wgContLang->convert( $nt->getText() );
$plink = Linker::link( $nt, htmlspecialchars( $text ) );