summaryrefslogtreecommitdiff
path: root/includes/specials/SpecialPopularpages.php
diff options
context:
space:
mode:
Diffstat (limited to 'includes/specials/SpecialPopularpages.php')
-rw-r--r--includes/specials/SpecialPopularpages.php14
1 files changed, 10 insertions, 4 deletions
diff --git a/includes/specials/SpecialPopularpages.php b/includes/specials/SpecialPopularpages.php
index 803f03e7..448d1799 100644
--- a/includes/specials/SpecialPopularpages.php
+++ b/includes/specials/SpecialPopularpages.php
@@ -42,9 +42,9 @@ class PopularPagesPage extends QueryPage {
function getQueryInfo() {
return array (
'tables' => array( 'page' ),
- 'fields' => array( 'page_namespace AS namespace',
- 'page_title AS title',
- 'page_counter AS value'),
+ 'fields' => array( 'namespace' => 'page_namespace',
+ 'title' => 'page_title',
+ 'value' => 'page_counter'),
'conds' => array( 'page_is_redirect' => 0,
'page_namespace' => MWNamespace::getContentNamespaces() ) );
}
@@ -56,7 +56,13 @@ class PopularPagesPage extends QueryPage {
*/
function formatResult( $skin, $result ) {
global $wgContLang;
- $title = Title::makeTitle( $result->namespace, $result->title );
+
+ $title = Title::makeTitleSafe( $result->namespace, $result->title );
+ if( !$title ) {
+ return Html::element( 'span', array( 'class' => 'mw-invalidtitle' ),
+ Linker::getInvalidTitleDescription( $this->getContext(), $result->namespace, $result->title ) );
+ }
+
$link = Linker::linkKnown(
$title,
htmlspecialchars( $wgContLang->convert( $title->getPrefixedText() ) )