From 91e194556c52d2f354344f930419eef2dd6267f0 Mon Sep 17 00:00:00 2001 From: Pierre Schmitz Date: Wed, 4 Sep 2013 05:51:59 +0200 Subject: Update to MediaWiki 1.21.2 --- tests/phpunit/TODO | 10 ++++++++++ 1 file changed, 10 insertions(+) create mode 100644 tests/phpunit/TODO (limited to 'tests/phpunit/TODO') diff --git a/tests/phpunit/TODO b/tests/phpunit/TODO new file mode 100644 index 00000000..b2fa7fb6 --- /dev/null +++ b/tests/phpunit/TODO @@ -0,0 +1,10 @@ +== Things To Do == +* Most of the tests are named poorly; naming should describe a use case in story-like language, not simply identify the +unit under test. An example would be the difference between testCalculate and testAddingIntegersTogetherWorks. +* Many of the tests make multiple assertions, and are thus not unitary tests. By using data-providers and more use-case +oriented test selection nearly all of these cases can be easily resolved. +* Some of the test files are either incorrectly named or in the wrong folder. Tests should be organized in a mirrored +structure to the source they are testing, and named the same, with the exception of the word "Test" at the end. +* Shared set-up code or base classes are present, but usually named improperly or appear to be poorly factored. Support +code should share as much of the same naming as the code it's supporting, and test and test-case depenencies should be +considered to resolve other shared needs. -- cgit v1.2.2