summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLuke Shumaker <lukeshu@lukeshu.com>2017-11-24 23:15:42 -0500
committerLuke Shumaker <lukeshu@lukeshu.com>2017-11-24 23:15:42 -0500
commit12a26fba6ee92d7a01b56301da8a1efae6bd58b0 (patch)
treef9f1520f0cdb306d0b51fc1c5c7a9102f3e4a3e8
parent06bc5a7047404869a1606deb49809001305d028f (diff)
add more comments
-rw-r--r--filter.go7
1 files changed, 7 insertions, 0 deletions
diff --git a/filter.go b/filter.go
index 50c3d19..0edecba 100644
--- a/filter.go
+++ b/filter.go
@@ -126,6 +126,10 @@ func (f *Filter) pkgbuild2srcinfo(pkgbuildId string) (string, error) {
}
}
+// I don't remember why I wrote this function. I obviously thought I
+// would need it. It's slow, and doesn't cache, so I figure I meant
+// for it to be called rarely. Perhaps for resuming incremental
+// conversion?
func gitsvnid2commit(gitsvnid string, searchrange string) (string, error) {
cmd := exec.Command("git", "log",
"-n1",
@@ -169,6 +173,9 @@ func (f *Filter) Run() error {
// TODO: I think I might need to issue
// a 'reset' command if
// f.refs[fc.metadata.Ref] isn't set.
+
+ // TODO: detect merges and add parents
+ // to fc.metadata.From
err = f.backend.Do(fc.metadata)
if err != nil {
return err