summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-08-13Merge pull request #9863 from evverx/issues-found-by-journald-fuzzersystemd/masterYu Watanabe
A few fixes for several issues uncovered with a home-brew fuzzer for journald
2018-08-13resolved: do not keep dns_server to dns_stream ref if tls connection failed ↵Iwan Timmer
(#9855) The references to the dns_server are now setup after the tls connection is setup. This ensures that the stream got fully stopped when the initial tls setup failed instead of having the unref being blocked by the reference to the stream by the server. Therefore on_stream_io would no longer be called with a half setup encrypted connection. Fixes the issue reported in #9838.
2018-08-13resolve: do not hit CNAME or DNAME entry in NODATA cache (#9836)Yu Watanabe
Fixes #9833.
2018-08-10fsck: use our usual syntax for defining bit masksLennart Poettering
2018-08-10Merge pull request #9848 from yuwata/fix-9835-9844Zbigniew Jędrzejewski-Szmek
core: namespace fixes
2018-08-10journald: take leading spaces into account in syslog_parse_identifierEvgeny Vereshchagin
This is a kind of follow-up to e88baee88fad8bc59d3 which should finally fix the issue which that commit was supposed to fix.
2018-08-10journald: free the allocated memory before returning from dev_kmsg_recordEvgeny Vereshchagin
This fixes a minor memory leak.
2018-08-10journald: make it clear that dev_kmsg_record modifies the string passed to itEvgeny Vereshchagin
The function replaces a couple commas, a semicolon and the final newline with zero bytes in the string passed to it. The 'const' seems to have been added by accident during a bulk edit (more specifically 3b3154df7e2773332bb814).
2018-08-10core/execute: fix dump format for Limit*=Yu Watanabe
Fixes #9846.
2018-08-10journal: do not remove multiple spaces after identifier in syslog messageYu Watanabe
Single space is used as separator. C.f. discussions in #156. Fixes #9839 introduced by a6aadf4ae0bae185dc4c414d492a4a781c80ffe5.
2018-08-10util: bind_remount_recursive_with_mountinfo(): ignore submounts which cannot ↵Yu Watanabe
be accessed Fixes #9844.
2018-08-10core/namespace: add more log messagesYu Watanabe
Suggested by #9835.
2018-08-10meson: actually honor pkgconfig*dir options (#9841)Benedikt Morbach
both were silently ignored leading to some of the pkg-config files ending up in the wrong place
2018-08-08timedate: emit property changed signal after all jobs are completedYu Watanabe
Follow-up for 3af0a96c0fcc623bd16649fc3640396a657cf9ef (#9684).
2018-08-08Merge pull request #9827 from yuwata/fix-9795-9820Lennart Poettering
journal: fixes issues reported by ASan
2018-08-08tmpfiles: don't adjust qgroups on existing subvolumesFranck Bui
The qgroup logic (types 'q' and 'Q') only has an effect if there's no previous setup at all, and any explicitly configured subvolumes with their qgroups are left entirely unmodified. The idea is that if users want a different logic than the one we set up by default, then by all means they should do that before hand, and tmpfiles won't override their logic.
2018-08-08resolve: do not compress target names in SRV recordsYu Watanabe
Fixes #9793.
2018-08-08Merge pull request #9830 from yuwata/journalctl-helpLennart Poettering
journal: do not hide options in help message
2018-08-08syslog: fix segfault in syslog_parse_priority()Yu Watanabe
2018-08-08kernel-install: don't try to run depmod when kernel doesn't support modulesMarc-Antoine Perennou
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
2018-08-08journal: fix size of bufferYu Watanabe
2018-08-08resolve: use memcmp_safe() and memcpy_safe()Yu Watanabe
As the length of salt in NSEC3 may be zero. Fixes #9757.
2018-08-08util: introduce memcmp_safe()Yu Watanabe
2018-08-08core: use memcpy_safe()Yu Watanabe
Fixes #9738.
2018-08-08journal: fix syslog_parse_identifier()Yu Watanabe
Fixes #9829.
2018-08-08journal: do not use newa() or strjoina() for messageYu Watanabe
Fixes another issue reported in #9795.
2018-08-08journal: do not hide options in help messageYu Watanabe
Even if built without gcrypt, show the relevant options in help message. Otherwise, the help message diverges from the man page or suggestions by the shell completion.
2018-08-08bash-completion: journalctl: add --grep and --case-sensitiveYu Watanabe
2018-08-08journal: do not pass a negative value to memcpy()Yu Watanabe
The message may contains only whitespaces. Fixes #9795.
2018-08-07link: fix type for link-config's "features" array of tristatesThomas Haller
The "features" fields is parsed as a tristate value. The values are thus not of type NetDevFeature enum but int. The NetDevFeature enum is instead the index for the features array. Adjust the type. In practice, this had no impact because NetDevFeature enum commonly has size of int. Also, don't use memset() 0xFF to initilize the int with -1. While it works correctly in practice, it feels ugly.
2018-08-07test: cast values in proper type to suppress warningsYu Watanabe
Follow-up for #9789.
2018-08-07Merge pull request #9817 from yuwata/shorten-error-loggingLennart Poettering
tree-wide: Shorten error logging and several code cleanups
2018-08-07Merge pull request #9744 from yuwata/fix-9737Lennart Poettering
Make RootImage= work with PrivateDevices=
2018-08-07hwdb: redefine Lenovo ThinkPad X140e touchpad dimensions (#9818)Michael 'pbone' Pobega
The default setup for the Lenovo ThinkPad X140e is 104x104mm, and the kernel claims that it's 64x21. The default 104x104mm dimensions causes the vertical axis to act oddly, causing random vertical jitters and higher vertical sensitivity. Measuring it showed that it was 74x32, and these touchpad dimensions provide a better (if a little bit slower) experience but a consistent sensitivity in all directions. These values were obtained using the `touchpad-edge-detector` tool.
2018-08-07Merge pull request #9789 from filbranden/cmp1Lennart Poettering
Add new CMP(a, b) macro
2018-08-07systemctl: add support for --wait to is-system-runningFilipe Brandenburger
This makes it possible to wait until boot is finished without having to poll for this command repeatedly, instead using the syntax: $ systemctl is-system-running --wait Waiting is implemented by waiting for the StartupFinished signal to be posted on the bus. Register the matcher before checking for the property to avoid race conditions. Tested by artificially delaying startup with a oneshot service and calling this command, checked that it emitted `running` and exited with a 0 return code as soon as the delay service completed startup. Also tested that booting to degraded state unblocks the command. Inserted a delay between getting the property and waiting for the signal and confirmed this seems to work free of race conditions. Updated the --help text (under --wait) and the man page to document the new feature.
2018-08-07tree-wide: use returned value from log_*_errno()Yu Watanabe
2018-08-06dns-domain: use CMP() in dns_name_compare_funcFilipe Brandenburger
2018-08-06resolve: use CMP() in dns_resource_record_compare_funcFilipe Brandenburger
This function doesn't really implement ordering, but CMP() is still fine to use there. Keep the comment in place, just update it slightly to indicate that.
2018-08-06tree-wide: Convert compare_func's to use CMP() macro wherever possible.Filipe Brandenburger
Looked for definitions of functions using the *_compare_func() suffix. Tested: - Unit tests passed (ninja -C build/ test) - Installed this build and booted with it.
2018-08-06network: Use CMP() macro for comparison.Filipe Brandenburger
Follow up for PRs #9764 and #9760.
2018-08-06macros: add CMP(a, b) macro.Filipe Brandenburger
Macro returns -1, 0, 1 depending on whether a < b, a == b or a > b. It's safe to use on unsigned types. Add tests to confirm corner cases are properly covered.
2018-08-06macro: drop __extension__, reformat and reindentFilipe Brandenburger
Drop __extension__, since we don't use gcc -Wpedantic or -ansi. Reformat code for spacing. Add spaces after commas almost everywhere. Reindent code blocks in macro definitions, for consistency.
2018-08-07tree-wide: shorten error logging a bitYu Watanabe
Continuation of 4027f96aa08c73f109aa46b89842ca0e25c9c0e9.
2018-08-07resolve: use _cleanup_ attributeYu Watanabe
2018-08-07machine: use free_and_replace() and TAKE_PTR()Yu Watanabe
2018-08-07login: use free_and_replace() and TAKE_PTR()Yu Watanabe
2018-08-07initctl: do not ignore errors in functionYu Watanabe
2018-08-07machinectl: shorten error logging a bitLennart Poettering
2018-08-06smack-util: use 'path' paremeter as is if it's already absolute in ↵Franck Bui
mac_smack_fix_at()