housekeeping - nornmalize _version_constraint() implementations across PKGBUILDs

1 files changed, 43 insertions, 5 deletions

diff --git a/pcr-testing/calamares/PKGBUILD b/pcr-testing/calamares/PKGBUILD
index 5d2a2524c..6c27f1e6e 100644
--- a/pcr-testing/calamares/PKGBUILD
+++ b/pcr-testing/calamares/PKGBUILD
@@ -19,16 +19,54 @@ source=(git+https://git.parabola.nu/${pkgname}.git#tag=v${pkgver}-${pkgrel%%.*})
 sha256sums=('SKIP')
 
 
-_version_constraint() # (dep_pkgname)
+_version_constraint() # (dep_pkgname [precision])
 {
+  Log() { [[ "${FUNCNAME[2]}" == package ]] && echo "$@" >&2 || : ; }
+
+
   local dep_pkgname=$1
-  local version=$(pacman -S --print-format='%v' ${dep_pkgname} | tail -n 1)
-  version=${version%-*}
-  local version_inc=${version%.*}.$(( ${version##*.} + 1 ))
+  declare -i req_precision=$2
+  local full_version=$(pacman -S --print-format='%v' ${dep_pkgname} 2> /dev/null | tail -n 1)
+  local n_dots=$(tmp=${full_version%-*} ; tmp=${tmp//[^\.]} ; echo "${#tmp}" ;)
+  local def_precision=$(( n_dots + 1 ))
+  local is_prec_valid=$(( req_precision > 0 && req_precision <= def_precision ))
+  local precision=$( (( is_prec_valid )) && echo ${req_precision} || echo ${def_precision} )
+  local pkgver_rx='[0-9A-Za-z_]+'
+  pkgver_rx=$(sed 's|\]|\+]|' <<<${pkgver_rx}) # according to the wiki, '+' is not allowed,
+                                               # but some pkgver have it (eg: 5.15.10+kde+r130)
+  local subver_rx='\.'${pkgver_rx}
+  local pkgrel_rx='[0-9]+'
+  local garbage_rx='[^0-9].*'
+  local capture_rx=${pkgver_rx}
+  for (( n_dots=1 ; n_dots < precision ; ++n_dots )) ; do capture_rx+=${subver_rx} ; done ;
+  local version pkgrel has_split_char version_min version_max constraint_string
+  declare -i subver subver_inc pkgrel_inc
+
+  if   [[ "${full_version}" =~ ^(${capture_rx})(${subver_rx})*-(${pkgrel_rx}).*$ ]]
+  then version=${BASH_REMATCH[1]} # pkgver cut to the requested precision
+       #unused=${BASH_REMATCH[2]} # discarded pkgver segments
+       pkgrel=${BASH_REMATCH[3]}  # pkgrel with non-numerics right-trimmed
+       has_split_char=$(grep '\.' <<<${version} &> /dev/null ; echo $((! $?)) ; )
+       subver=$(sed "s|${garbage_rx}||" <<<${version##*.}) # right-trim from any non-numeric
+       version=$( ((has_split_char)) && echo ${version%.*}.${subver} || echo ${subver} )
+       subver_inc=$(( subver + 1 ))
+       pkgrel_inc=$(( pkgrel + 1 ))
+       version_min=$(   (( ! is_prec_valid    )) && echo ${full_version%-*}-${pkgrel} || \
+                                                    echo ${version}                      )
+       version_max=$( ( (( ! is_prec_valid    )) && echo ${full_version%-*}-${pkgrel_inc} ) || \
+                      ( [[ "${version}" =~ \. ]] && echo ${version%.*}.${subver_inc}      ) || \
+                                                    echo ${subver_inc}                         )
+       constraint_string="${dep_pkgname}>=${version_min} ${dep_pkgname}<${version_max}"
 
-  echo -n "${dep_pkgname}>=${version}" "${dep_pkgname}<${version_inc}"
+       Log "Applied version constraint: '${constraint_string}'"
+  else Log "ERROR: in _version_constraint() parsing: dep_pkgname='${dep_pkgname}' full_version='${full_version}'"
+       exit 1
+  fi
+
+  echo -n "${constraint_string}"
 }
 
+
 prepare()
 {
   cd "${srcdir}"/${pkgname}/