| Age | Commit message (Collapse) | Author |
|---|
|
|
|
Objectives:
- Once the source package has been created, never run makepkg with
networking enabled again, so that we can be 100% sure that the source
package has all of the sources that we need.
- Don't let makepkg edit the PKGBUILD (eg. by evaluating pkgver())
User-facing changes:
- libremakepkg now disables networking during prepare()
- libremakepkg no longer runs pkgver()
- chcleanup (and thus `librechroot clean-pkgs`) now also installs packages
Technical description of changes:
- In devtools (and not really in this commit):
* No longer split /chrootprepare off of /chrootbuild. The point of
splitting it was that we'd have prepare() run from /chrootprepare
and the rest later run from /chrootbuild, so that we could leave
networking enabled during prepare() but not the rest. Now that we're
disabling networking during prepare(), that's pointless.
* Have download_sources create a source package (rather than having
/chrootbuild create the source package at the same time that we create
the binary package). We adjust the caller to temporarily set
SRCPKGDEST to a temporary directory, so that we can get the file and
control the filename when we move it in to the real SRCPKGDEST.
- Have chcleanup install the dependencies. If we used the traditional
`makepkg --sync` to install the dependencies, then we'd be breaking the
"no networking for makepkg after source package creation" objective.
chcleanup already has all of the logic necessary to accomplish this.
If there's a discrepancy in chcleanup behavior and makepkg behavior, and
makepkg thinks it needs to install something, then that just means we'll
have to fix the bug in chcleanup, instead of letting it go for more than
a year (*cough* https://labs.parabola.nu/issues/1311 *cough*).
- Use files extracted from the source package (rather than files found in
the current directory) to build the package.
- We mount the temporary directory containing the extracted source package
files read-only, to be sure that makepkg doesn't modify the PKGBUILD.
This is necessary because --holdver only disables pkgver() if it's a VCS
package.
|
|
|
|
|
|
|
|
Also, don't parse PKGBUILD ourself; use .SRCINFO to extract
information from the PKGBUILD.
|
|
|
|
db-import-pkg now makes sure that that doesn't happen.
|
|
libremakepkg defined a cleanup() function, which overrode
common.sh:cleanup(), which meant that common.sh:die() exited with a
'0' status.
|
|
Do this by syncing makepkg_args with makechrootpkg's
default_makepkg_args; recent devtools have makechrootpkg not copy the
keyring in to the chroot.
This incorporates 3 commits from Arch devtools:
7ca4eb82d (2017-05-02): add --holdver
0cbc179d2 (2017-07-13): use long options; `-s`→`--syncdeps`, `-L`→`--log`
75fdff181 (2017-07-13): add --skipinteg
|
|
|
|
I intend to have xbs-abs have separate libdir / libexecdir s.
|
|
This should have been in 314f2c9b1daac8c47d78754569a7310d0b77e22b.
|
|
in the light of my attempts to create a riscv64 parabola port, I would
like to see the following changes made to librechroot.
The patch removes the hard-coded arm cross arch checks in favour of a
more general approach, that works for more architectures. As a side
effect, this now also would behave correctly when creating x86 chroots
on arm, although why anyone would choose to do this is beyond me.
Reviewed-By: Luke Shumaker <lukeshu@parabola.nu>
[LS: Added quotes]
|
|
|
|
|
|
|
|
|
|
|
|
This has been sitting uncommitted in my checkout for a while.
This has been sitting uncommitted in my checkout for a while.
|
|
|
|
https://lists.parabola.nu/pipermail/dev/2017-June/005576.html
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
The old way fails in weird ways if a process dies early.
|
|
|
|
|
|
|
|
Only make this change in places where it shouldn't make a difference, and
something weird has to be going on for the subshell to fail. This is on
par with checking the return value of malloc. We don't need tests for each
of these failure cases.
|
|
These were found with the help of shellcheck.
|
|
These were found with the help of shellcheck.
Nothing more complicated than wrapping a variable in double quotes has been
done.
|
|
|
|
I changed how it works in devtools-par.
|
|
makechrootpkg.sh has now been patched to make it ok with `set -euE`.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
